Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextPopup - unique values from projets, not sortedProjects #1849

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

entrotech
Copy link
Member

What changes did you make?

  • There was a problem with the implementation. When a filter by text already existed and the popup was opened, the uniqueValues list was based on the sortedProjects, which was already filtered by the previously selected text. This meant that the drop-down list to choose from only included the text strings that already met the previous sort string, so it was not possible to remove the filter or remove characters from the search string. The only way to change the search string was to push "reset", then "apply", then re-open the text popup.
  • Fixed by making the uniqueValues based on (unsorted / unfiltered) projects.

@entrotech entrotech merged commit cb24fc9 into develop Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant